-
Notifications
You must be signed in to change notification settings - Fork 3.8k
improvement(ci): move CodeQL off default setup onto Blacksmith #6219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+127
−0
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| name: Sim CodeQL config | ||
|
|
||
| # Trims the extraction surface. CodeQL parses every matching file into a | ||
| # database before a single query runs, and that phase dominates runtime on a | ||
| # ~12.7k-file JS/TS tree. Test and fixture code is not attacker-reachable, so | ||
| # excluding it costs no real coverage. | ||
| # | ||
| # paths-ignore applies to analysis. The workflow's `on.pull_request.paths` | ||
| # filter is separate and decides whether the run happens at all. | ||
| paths-ignore: | ||
| - '**/*.test.ts' | ||
| - '**/*.test.tsx' | ||
| - '**/*.test.js' | ||
| - '**/*.spec.ts' | ||
| - '**/*.spec.tsx' | ||
| - '**/__tests__/**' | ||
| - '**/__mocks__/**' | ||
| - '**/__fixtures__/**' | ||
| - '**/e2e/**' | ||
| # Deliberately no '**/test/**' or '**/tests/**'. A directory named `test` is a | ||
| # routable Next.js path segment, not necessarily test code: those globs | ||
| # excluded the real endpoint | ||
| # apps/sim/app/api/organizations/[id]/data-drains/[drainId]/test/route.ts, | ||
| # which authorizes, decrypts destination credentials, and makes an outbound | ||
| # request. CodeQL's paths-ignore has no `!` negation to carve it back out | ||
| # ("The filter pattern characters ?, +, [, ], and ! are not supported and will | ||
| # be matched literally"), and the globs only covered 76 of 12,716 files, so | ||
| # the naming convention above is the safer filter. | ||
| - '**/*.d.ts' | ||
| - '**/node_modules/**' | ||
| - '**/dist/**' | ||
| - '**/.next/**' | ||
| - 'apps/docs/content/**' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| name: CodeQL | ||
|
|
||
| # Advanced setup, replacing the repo-settings "default setup". | ||
| # | ||
| # Default setup pinned every scan to a 4-vCPU GitHub-hosted runner with no | ||
| # cancel-in-progress, which put PR scans at 30-125 min and re-ran them on every | ||
| # push (PR #6183 burned six overlapping runs). None of that is configurable from | ||
| # the settings UI, so the config moves into the repo. | ||
| # | ||
| # Before enabling this, disable default setup or the two will both run: | ||
| # gh api -X PATCH repos/:owner/:repo/code-scanning/default-setup -f state=not-configured | ||
| # | ||
| # The runs-on expression is the same CI_PROVIDER escape hatch as ci.yml and must | ||
| # change together with it. | ||
|
|
||
| on: | ||
| # Pushes to main are infrequent (merges only), so a full scan per push is | ||
| # affordable and is what GitHub recommends pairing with the PR trigger: | ||
| # "Scanning code when someone pushes a change, and whenever a pull request is | ||
| # created, prevents developers from introducing new vulnerabilities." | ||
| push: | ||
| branches: [main] | ||
| pull_request: | ||
| branches: [main, staging] | ||
| # `ready_for_review` is not a default activity type, so it has to be listed | ||
| # alongside the defaults it replaces. Without it, a PR opened as a draft and | ||
| # then marked ready is skipped by the job-level draft guard and never | ||
| # rescanned until the next push. | ||
| types: [opened, synchronize, reopened, ready_for_review] | ||
| paths: | ||
| - '**/*.ts' | ||
| - '**/*.tsx' | ||
| - '**/*.js' | ||
| - '**/*.jsx' | ||
| - '**/*.mjs' | ||
| - '**/*.cjs' | ||
| - '.github/workflows/**' | ||
| - '.github/actions/**' | ||
| - '.github/codeql/**' | ||
| schedule: | ||
| # Safety net behind the push trigger, and the thing that keeps the | ||
| # default-branch alert view fresh when main is quiet. Only fires once this | ||
| # file is on the default branch — schedule events ignore other branches. | ||
| - cron: '17 8 * * *' | ||
| workflow_dispatch: | ||
|
|
||
| # Scheduled main scans must run to completion — only PR pushes supersede. | ||
| concurrency: | ||
| group: codeql-${{ github.ref }} | ||
| cancel-in-progress: ${{ github.event_name == 'pull_request' }} | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| analyze: | ||
| name: Analyze ${{ matrix.language }} | ||
| runs-on: ${{ (vars.CI_PROVIDER == '' || vars.CI_PROVIDER == 'blacksmith') && 'blacksmith-8vcpu-ubuntu-2404' || 'ubuntu-latest' }} | ||
| timeout-minutes: 60 | ||
| if: github.event.pull_request.draft != true | ||
| permissions: | ||
| security-events: write | ||
| contents: read | ||
| actions: read | ||
|
|
||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| # One entry covers both JS and TS — `javascript`, `typescript` and | ||
| # `javascript-typescript` all resolve to the same extractor | ||
| # (github/codeql-action src/languages/builtin.json), so the three | ||
| # entries default setup listed were one analysis, not three. | ||
| # `javascript-typescript` is the documented spelling. Python dropped: | ||
| # 7 files in the tree. | ||
| language: [javascript-typescript, actions] | ||
|
|
||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@fbc6f3992d24b796d5a048ff273f7fcc4a7b6c09 # v5 | ||
| with: | ||
| persist-credentials: false | ||
|
|
||
| - name: Initialize CodeQL | ||
| uses: github/codeql-action/init@18420e3271f74589575af831a523c833acda327f # codeql-bundle-v2.26.2 | ||
| with: | ||
| languages: ${{ matrix.language }} | ||
| config-file: ./.github/codeql/codeql-config.yml | ||
|
|
||
| - name: Perform CodeQL Analysis | ||
| uses: github/codeql-action/analyze@18420e3271f74589575af831a523c833acda327f # codeql-bundle-v2.26.2 | ||
| env: | ||
| NODE_OPTIONS: --max-old-space-size=8192 | ||
|
waleedlatif1 marked this conversation as resolved.
|
||
| with: | ||
| category: /language:${{ matrix.language }} | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.