feat(blocks): add min_lines/max_lines to RichTextInputElement - #1925
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1925 +/- ##
==========================================
+ Coverage 84.14% 84.17% +0.03%
==========================================
Files 118 118
Lines 13423 13425 +2
==========================================
+ Hits 11295 11301 +6
+ Misses 2128 2124 -4 ☔ View full report in Codecov by Harness. |
srtaalej
marked this pull request as ready for review
July 29, 2026 17:48
zimeg
approved these changes
Jul 29, 2026
zimeg
left a comment
Member
There was a problem hiding this comment.
🙏 Awesome to find these options supported as expected arguments! LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds optional
min_linesandmax_linesinteger properties to theRichTextInputElementBlock Kit model, allowing developers to control the visible height ofrich_text_inputelements.min_lines— minimum number of visible lines (1–100)max_lines— maximum number of visible lines before scrolling (1–100, defaults to 8 on the platform when unset)Both properties are optional, preserving full backward compatibility.
Testing
New test methods:
test_min_lines,test_max_lines,test_min_and_max_lines— all verify round-trip serialization.Test app.py
Category
tests/integration_tests(Automated tests for this library)Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.