HYBIM-948 refresh README and changelog for first Splunk AO release - #195
Conversation
fercor-cisco
left a comment
There was a problem hiding this comment.
🤖 This review was generated by the Astra agent (claude-opus-4-8). It may contain mistakes.
Verdict: request_changes — The new "Export diagnostics" docs describe a public attribute (processor.export_health) and rejection/recovery/logger behavior that do not exist in the source.
@fercor-cisco This branch now includes all missing changes from other PRs. Please check. Thank you :). |
fercor-cisco
left a comment
There was a problem hiding this comment.
🤖 This review was generated by the Astra agent (claude-opus-4-8). It may contain mistakes.
Verdict: approve — Documentation-only PR; all documented APIs, env vars, and behaviors verified accurate against the source.
Follow-ups
Suggested follow-up work that could be tracked as Jira tickets:
README.md:295-311: The OpenAI streaming example (pre-existing, outside this PR's edits) does not call flush() or terminate(). In a finite script the completed span may never be exported before the process exits, unlike the other examples in this refresh which now consistently show explicit flush()/terminate(). Consider aligning it with the new guidance in a later pass.src/splunk_ao/decorator.py:1404-1415: The docstring for splunk_ao_context.init() still documents a 'log_stream' parameter that no longer exists (the parameter is 'agent_stream'). This source docstring is out of scope for a docs PR but is now inconsistent with the README's Agent Stream terminology and could be updated for consistency.
|
Filed follow-up stories under epic HYBIM-697 for the review items deferred from this PR:
|
…adme-changelog # Conflicts: # README.md # splunk-ao-a2a/README.md
Summary
Refresh the README and changelog for the first Splunk AO Python SDK release, covering standalone and O11y configuration and the SDK’s OTLP based telemetry behavior.
Why
The existing documentation described legacy Galileo behavior and did not accurately explain current routing, lifecycle, batching, authentication, diagnostics, and OpenTelemetry integration requirements.
What changed
@log, handler, manual logger,flush(),terminate(), and provider shutdown behavior.Documentation corrections
SPLUNK_AO_O11Y_TOKENandSPLUNK_AO_O11Y_API_TOKEN.Tests
Validated 23 Python examples, 9 shell examples, 76 focused tests.