chore: fix C lint errors (issue #13733) - #13741
Open
A-S-Manoj wants to merge 1 commit into
Open
Conversation
Signed-off-by: A Sivasubramanian Manoj <ph0en1x.1ncog@gmail.com>
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #13733.
Description
This pull request:
lib/node_modules/@stdlib/strided/base/smap/examples/c/example.cby declaring the input arrayXasconst, since it is only read from (passed asconst float *Xtostdlib_strided_smap) and never modified.Related Issues
This pull request has the following related issues:
Questions
No.
Other
Verified locally with
cppcheck --enable=style: the warning is present before the change and gone after. Also confirmed the change compiles cleanly withgcc -Wall -Wextraand matches the existing convention used in sibling examples (e.g.dmap's example already declares its input arrayconst).Checklist
AI Assistance
@stdlib-js/reviewers