fix: apply follow-up fixes from develop commit review (2026-07-29) - #13752
Draft
Planeshifter wants to merge 4 commits into
Draft
fix: apply follow-up fixes from develop commit review (2026-07-29)#13752Planeshifter wants to merge 4 commits into
Planeshifter wants to merge 4 commits into
Conversation
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
developbetween 2026-07-28 13:39 (PT) (7c34546) and 2026-07-29 01:11 (PT) (39a2ecc)Fixes, grouped by package:
blas/ext/base/clogspacestdlib_strided_clogspace_ndarrayinblas/ext/base/clogspace/src/main.c:ce25df4declared the loop boundMand counteriasfloat, usingi += 1.0fto advance. Single-precision floats stop representing consecutive integers past 2^24, so forN > 2^24+1the increment silently becomes a no-op, the loop never terminates, andix += strideXkeeps writing past the end of the output buffer. DeclareMandiasCBLAS_INTand loop over integers, matchingslogspace/slinspace;zlogspaceis unaffected since itsdoublecounters are exact over the full index range.blas/ext/base/gindex-of-truthy-row@throwsannotation for the fifth argument inlib/node_modules/@stdlib/blas/ext/base/gindex-of-truthy-row/lib/main.js, added in981dfaf, to match the actualRangeErrormessage ("must be greater than or equal to max(1,N)") rather than the stale "must be a valid stride length" text. Brings the doc in line with the siblinggindex-of-rowpackage.math/base/special/acotandmath/base/special/acoth@stdlib/assert/is-almost-same-valueinstead of the low-level@stdlib/number/float64/base/assert/is-almost-same-valuepulled in byf38253d(acoth) andbf8f11d(acot), matching the convention used by all other migratedmath/base/specialfloat64 test suites. Updatestest.jsandtest.native.jsinmath/base/special/acotandmath/base/special/acoth.Related Issues
No.
Questions
No.
Other
Validation performed on the review window (24 commits,
7c34546^..39a2ecc):docs/style-guidesand established reference packages (slogspace,slinspace,gindex-of-row,gsorthp, already-migrated ULP test suites).blas/ext/basepackages (dwxpy,clogspace,gindex-of-truthy-row,gsorthp-by), fuzz-testing against brute-force references, and comparing JS and C kernel implementations.acot/acothtest suites pass after the import change (5029 and 6027 assertions, 0 failures); the editedclogspace/src/main.ccompiles cleanly with-Wall -Wextra.Deliberately excluded: subjective concerns, style preferences not required by the style guides, and anything requiring changes outside the review window's diff to validate or fix.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written by Claude Code as part of an automated review of commits recently merged to
develop; all fixes were verified by running the affected test suites and syntax-checking the C changes.Generated by Claude Code