Skip to content

fix: apply follow-up fixes from develop commit review (2026-07-29) - #13752

Draft
Planeshifter wants to merge 4 commits into
developfrom
philipp/fix-commit-review-2026-07-29
Draft

fix: apply follow-up fixes from develop commit review (2026-07-29)#13752
Planeshifter wants to merge 4 commits into
developfrom
philipp/fix-commit-review-2026-07-29

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Description

What is the purpose of this pull request?

This pull request:

  • applies follow-up fixes for commits merged to develop between 2026-07-28 13:39 (PT) (7c34546) and 2026-07-29 01:11 (PT) (39a2ecc)

Fixes, grouped by package:

blas/ext/base/clogspace

  • Fix stdlib_strided_clogspace_ndarray in blas/ext/base/clogspace/src/main.c: ce25df4 declared the loop bound M and counter i as float, using i += 1.0f to advance. Single-precision floats stop representing consecutive integers past 2^24, so for N > 2^24+1 the increment silently becomes a no-op, the loop never terminates, and ix += strideX keeps writing past the end of the output buffer. Declare M and i as CBLAS_INT and loop over integers, matching slogspace/slinspace; zlogspace is unaffected since its double counters are exact over the full index range.

blas/ext/base/gindex-of-truthy-row

  • Fix @throws annotation for the fifth argument in lib/node_modules/@stdlib/blas/ext/base/gindex-of-truthy-row/lib/main.js, added in 981dfaf, to match the actual RangeError message ("must be greater than or equal to max(1,N)") rather than the stale "must be a valid stride length" text. Brings the doc in line with the sibling gindex-of-row package.

math/base/special/acot and math/base/special/acoth

  • Fix acot/acoth ULP tests to require @stdlib/assert/is-almost-same-value instead of the low-level @stdlib/number/float64/base/assert/is-almost-same-value pulled in by f38253d (acoth) and bf8f11d (acot), matching the convention used by all other migrated math/base/special float64 test suites. Updates test.js and test.native.js in math/base/special/acot and math/base/special/acoth.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

Validation performed on the review window (24 commits, 7c34546^..39a2ecc):

  • Style-guide compliance audit of all changed code against docs/style-guides and established reference packages (slogspace, slinspace, gindex-of-row, gsorthp, already-migrated ULP test suites).
  • Two independent bug scans over the introduced code, including running the test suites of the new blas/ext/base packages (dwxpy, clogspace, gindex-of-truthy-row, gsorthp-by), fuzz-testing against brute-force references, and comparing JS and C kernel implementations.
  • The acot/acoth test suites pass after the import change (5029 and 6027 assertions, 0 failures); the edited clogspace/src/main.c compiles cleanly with -Wall -Wextra.

Deliberately excluded: subjective concerns, style preferences not required by the style guides, and anything requiring changes outside the review window's diff to validate or fix.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

This PR was written by Claude Code as part of an automated review of commits recently merged to develop; all fixes were verified by running the affected test suites and syntax-checking the C changes.


Generated by Claude Code

@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/clogspace $\\color{green}564/564$
$\\color{green}+100.00\\%$
$\\color{green}24/24$
$\\color{green}+100.00\\%$
$\\color{green}4/4$
$\\color{green}+100.00\\%$
$\\color{green}564/564$
$\\color{green}+100.00\\%$
blas/ext/base/gindex-of-truthy-row $\\color{green}348/348$
$\\color{green}+100.00\\%$
$\\color{green}43/43$
$\\color{green}+100.00\\%$
$\\color{green}3/3$
$\\color{green}+100.00\\%$
$\\color{green}348/348$
$\\color{green}+100.00\\%$
math/base/special/acot $\\color{green}186/186$
$\\color{green}+100.00\\%$
$\\color{green}5/5$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}186/186$
$\\color{green}+100.00\\%$
math/base/special/acoth $\\color{green}175/175$
$\\color{green}+100.00\\%$
$\\color{green}5/5$
$\\color{green}+100.00\\%$
$\\color{green}2/2$
$\\color{green}+100.00\\%$
$\\color{green}175/175$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants