feat(speculation): speculator extension contract - #445
Merged
Conversation
This was referenced Jul 27, 2026
behinddwalls
marked this pull request as ready for review
July 27, 2026 19:00
behinddwalls
marked this pull request as draft
July 27, 2026 20:45
behinddwalls
marked this pull request as ready for review
July 27, 2026 23:17
behinddwalls
force-pushed
the
preetam/speculation-speculator
branch
from
July 27, 2026 23:18
648e491 to
d89bfe4
Compare
behinddwalls
force-pushed
the
preetam/speculation-speculator
branch
from
July 28, 2026 19:13
d89bfe4 to
648e491
Compare
sbalabanov
approved these changes
Jul 28, 2026
behinddwalls
force-pushed
the
preetam/speculation-speculator
branch
from
July 29, 2026 18:24
648e491 to
f9397ba
Compare
behinddwalls
force-pushed
the
preetam/speculation-speculator
branch
from
July 29, 2026 22:31
f9397ba to
9698e2a
Compare
behinddwalls
force-pushed
the
preetam/speculation-speculator
branch
from
July 29, 2026 22:41
9698e2a to
d9aaca5
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to invalid changes in the merge commit
Jul 29, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to invalid changes in the merge commit
Jul 29, 2026
Add submitqueue/extension/speculation/speculator: the Speculator interface — the one speculation extension the speculate controller calls — with Config, Factory, and mocks. A Speculator decides which paths to build and which running ones to cancel within the queue's build budget; verdicts stay controller-owned, so a swapped-in implementation changes which paths run, never a batch's outcome. Speculate's doc spells out the contract formally: what batches and pathSets contain, what the returned actions mean (empty result = nothing to change; order carries no meaning), and the error contract — plain unclassified errors for infrastructure failures only, context errors passed through, and an abandoned run retried by the next dirty signal.
behinddwalls
force-pushed
the
preetam/speculation-speculator
branch
from
July 29, 2026 23:18
d9aaca5 to
9dca221
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add submitqueue/extension/speculation/speculator: the Speculator interface — the one speculation extension the speculate controller calls — with Config, Factory, and mocks. A Speculator decides which paths to build and which running ones to cancel within the queue's build budget; verdicts stay controller-owned, so a swapped-in implementation changes which paths run, never a batch's outcome.
Speculate's doc spells out the contract formally: what batches and pathSets contain, what the returned actions mean (empty result = nothing to change; order carries no meaning), and the error contract — plain unclassified errors for infrastructure failures only, context errors passed through, and an abandoned run retried by the next dirty signal.
Stack