chore(submitqueue): remove dead pusher extension - #457
Draft
behinddwalls wants to merge 1 commit into
Draft
Conversation
## Summary ### Why? The `pusher` extension is dead code. Merge execution moved to Runway, where the pluggable contract is `runway/extension/merger` — a Runway-owned interface that takes a `MergeRequest` off the queue rather than SubmitQueue `entity.Batch` values. Nothing in the tree imports `submitqueue/extension/pusher` any more: the only remaining references were the package's own files and the `mocks` target in the Makefile. Removing it now keeps a second, divergent merge contract from drifting alongside the live one. ### What? Deletes the whole `submitqueue/extension/pusher` tree — the `Pusher`/`Factory` contract, the git-backed implementation, the fake, and the generated mock. Drops `./submitqueue/extension/pusher/...` from the `go generate` invocation in the `mocks` Makefile target. Left in place it would point `make mocks` at a path that no longer exists. Drops the stale `pusher` mention from the `changeset` package docs, which listed it as an example of a decision/action extension resolving content through a `Resolver`. ## Test Plan ✅ `make gazelle` — no BUILD churn beyond the deleted packages ✅ `make fmt` ✅ `make test` — 77/77 pass ✅ `grep -rn "extension/pusher"` over the tree returns nothing
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why?
The
pusherextension is dead code. Merge execution moved to Runway, where the pluggable contract isrunway/extension/merger— a Runway-owned interface that takes aMergeRequestoff the queue rather than SubmitQueueentity.Batchvalues. Nothing in the tree importssubmitqueue/extension/pusherany more: the only remaining references were the package's own files and themockstarget in the Makefile.Removing it now keeps a second, divergent merge contract from drifting alongside the live one.
What?
Deletes the whole
submitqueue/extension/pushertree — thePusher/Factorycontract, the git-backed implementation, the fake, and the generated mock.Drops
./submitqueue/extension/pusher/...from thego generateinvocation in themocksMakefile target. Left in place it would pointmake mocksat a path that no longer exists.Drops the stale
pushermention from thechangesetpackage docs, which listed it as an example of a decision/action extension resolving content through aResolver.Test Plan
✅
make gazelle— no BUILD churn beyond the deleted packages✅
make fmt✅
make test— 77/77 pass✅
grep -rn "extension/pusher"over the tree returns nothingStack