Skip to content

refactor: consolidate Device folder feature - #321

Open
jderochervlk wants to merge 1 commit into
codex/option5-file-folderfrom
codex/option5-device-folder
Open

refactor: consolidate Device folder feature#321
jderochervlk wants to merge 1 commit into
codex/option5-file-folderfrom
codex/option5-device-folder

Conversation

@jderochervlk

@jderochervlk jderochervlk commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Tracking issue: #342

Stack context

Part 11 of the Option 5 folder-feature stack.

Review this PR as the incremental diff against #320.

Summary

  • add the target src/device folder on the unqualified internal Device feature
  • merge Gamepad haptics, Geolocation, Web Locks, Screen Wake Lock, and Web MIDI into that complete folder
  • replace five qualified source features with the supported WebAPI.Device bundle
  • define WebAPI.Device -> WebAPI.Event + Device
  • preserve all existing flat public interface modules

Temporary state

  • this PR introduces no exclusions, compatibility aliases, or module slices; the Device folder membership and public implication are final
  • the domain-specific *Types helpers remain private inside the correct folder pending final cleanup

Review focus

  • the coarse Device bundle membership
  • removal of the five former consumer-facing feature names
  • preservation of public module paths and binding signatures

Verification

  • node_modules/.bin/rescript clean
  • node_modules/.bin/rescript build --prod --features DOM,Event,Device
  • npm run build
  • npm test
  • npm run format:check
  • git diff --check

Copy link
Copy Markdown
Collaborator Author

@codex

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep them coming!

Reviewed commit: dcd9372385

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jderochervlk
jderochervlk force-pushed the codex/option5-device-folder branch from dcd9372 to 58bdba1 Compare August 4, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant