refactor: establish Geometry folder feature - #324
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2844c280fd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "WebAPI.Event": ["WebAPI.DOM", "Event"], | ||
| "WebAPI.DOMPlatform": ["WebAPI.Event", "DOMPlatform"], | ||
| "WebAPI.Animation": ["WebAPI.Event", "Animation"], | ||
| "WebAPI.Geometry": ["WebAPI.DOM", "Geometry"], |
There was a problem hiding this comment.
Keep the Geometry feature off the unbuildable DOM slice
When a consumer selects --features WebAPI.Geometry, the CLI transitively compiles implied features (as documented by rescript build --help), so this activates the broad source slice tagged WebAPI.DOM, not just the dependency-clean core DOM feature. That slice cannot currently compile selectively: DOMTree.res requires DOMStringMap from DOMPlatform, while TextTrackList.res requires EventTarget from Event, producing missing-module errors before any Geometry API can be used. The reported --features DOM,Geometry verification bypasses this new mapping; until the broad DOM slice is dependency-clean, this facade needs to imply DOM and Geometry directly or include all of the DOM slice's dependencies.
Useful? React with 👍 / 👎.
2844c28 to
e945bdc
Compare
Tracking issue: #342
Stack context
Part 14 of the Option 5 folder-feature stack.
Review this PR as the incremental diff against #323.
Summary
src/geometryfolder on the unqualified internalGeometryfeatureWebAPI.Geometryfeature with itsWebAPI.DOMdependencyTemporary state
DOM.*geometry records introduced by the earlier compatibility cleanup; the final cleanup layer will make the owning Geometry modules authoritative after all consumers moveReview focus
WebAPI.Geometry -> WebAPI.DOM + GeometryimplicationVerification
node_modules/.bin/rescript cleannode_modules/.bin/rescript build --prod --features DOM,Geometrynpm run buildnpm testnpm run format:checkgit diff --check