refactor: establish Observers folder feature - #331
Open
jderochervlk wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
jderochervlk
force-pushed
the
codex/option5-observers-folder
branch
from
August 4, 2026 17:31
b030632 to
f91f011
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue: #342
Stack context
Part 21 of the Option 5 folder-feature stack.
Review this PR as the incremental diff against #330.
Summary
src/observersfolder on the unqualified internalObserversfeatureWebAPI.Observers -> WebAPI.DOMNodes + WebAPI.Geometry + Observersfeatureinstanceof Documentcheck inIntersectionObserverRootso the observer feature does not depend on the broad legacyDocumentmoduleDependency note
IntersectionObserverRootpreviously importedDocumentonly for its runtime type check. Its public type already uses foundationalDOM.document; keeping the check local removes an otherwise unnecessary dependency on the still-broad Document interface without changing the decoded result.Temporary state
Documentremains in the legacy DOM folder until the later Window/document integration layerWebAPI.DOMsource entry remains until its remaining interfaces have been assignedReview focus
Verification
node_modules/.bin/rescript cleannode_modules/.bin/rescript build --prod --features DOM,Event,DOMPlatform,Animation,CSSOM,Geometry,DOMNodes,Observersnpm run buildnpm testnpm run format:checkgit diff --check