Skip to content

refactor: establish Observers folder feature #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jderochervlk wants to merge 1 commit into from
Open

refactor: establish Observers folder feature #331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 10 additions & 19 deletions rescript.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@
"WebAPI.Media": ["WebAPI.HTML", "Media"],
"WebAPI.WebAudio": ["WebAPI.Media", "WebAPI.Messaging", "WebAudio"],
"WebAPI.SVG": ["WebAPI.DOMNodes", "WebAPI.Geometry", "SVG"],
"WebAPI.Observers": [
"WebAPI.DOMNodes",
"WebAPI.Geometry",
"Observers"
],
"WebAPI.File": ["WebAPI.Event", "File"],
"WebAPI.URL": ["WebAPI.DOM", "URL"],
"WebAPI.Fetch": ["WebAPI.Event", "WebAPI.File", "WebAPI.URL", "Fetch"],
Expand Down Expand Up @@ -361,12 +366,14 @@
]
},
{
"dir": "src/IntersectionObserver",
"dir": "src/observers",
"subdirs": true,
"feature": "WebAPI.IntersectionObserver",
"feature": "Observers",
"public": [
"IntersectionObserver",
"IntersectionObserverRoot"
"IntersectionObserverRoot",
"MutationObserver",
"ResizeObserver"
]
},
{
Expand Down Expand Up @@ -402,14 +409,6 @@
"VideoPlaybackQuality"
]
},
{
"dir": "src/MutationObserver",
"subdirs": true,
"feature": "WebAPI.MutationObserver",
"public": [
"MutationObserver"
]
},
{
"dir": "src/performance",
"subdirs": true,
Expand All @@ -428,14 +427,6 @@
"Permissions"
]
},
{
"dir": "src/ResizeObserver",
"subdirs": true,
"feature": "WebAPI.ResizeObserver",
"public": [
"ResizeObserver"
]
},
{
"dir": "src/ServiceWorker",
"subdirs": true,
Expand Down
0 ...rsectionObserver/IntersectionObserver.res → src/observers/IntersectionObserver.res
View file
Open in desktop
File renamed without changes.
4 changes: 3 additions & 1 deletion ...tionObserver/IntersectionObserverRoot.res → src/observers/IntersectionObserverRoot.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,12 @@ type decoded =
| Document(DOM.document)
| Null

let isDocument = (_: 't): bool => %raw(`param instanceof Document`)

let decode = (t: IntersectionObserverTypes.root): decoded => {
if Element.isInstanceOf(t) {
Element(t->toElement)
} else if Document.isInstanceOf(t) {
} else if isDocument(t) {
Document(t->toDocument)
} else {
Null
Expand Down
0 ...ionObserver/IntersectionObserverTypes.res → src/observers/IntersectionObserverTypes.res
View file
Open in desktop
File renamed without changes.
0 src/MutationObserver/MutationObserver.res → src/observers/MutationObserver.res
View file
Open in desktop
File renamed without changes.
0 src/ResizeObserver/ResizeObserver.res → src/observers/ResizeObserver.res
View file
Open in desktop
File renamed without changes.
0 src/ResizeObserver/ResizeObserverTypes.res → src/observers/ResizeObserverTypes.res
View file
Open in desktop
File renamed without changes.