refactor: establish Canvas folder feature - #333
Open
jderochervlk wants to merge 1 commit into
Open
Conversation
Collaborator
Author
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0c1e77a24d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jderochervlk
force-pushed
the
codex/option5-canvas-folder
branch
2 times, most recently
from
August 5, 2026 12:14
b28c6cf to
9eb1540
Compare
jderochervlk
force-pushed
the
codex/option5-canvas-folder
branch
3 times, most recently
from
August 5, 2026 13:40
c28014c to
ba04a65
Compare
jderochervlk
force-pushed
the
codex/option5-canvas-folder
branch
2 times, most recently
from
August 5, 2026 14:00
03332a9 to
c4b7dec
Compare
jderochervlk
force-pushed
the
codex/option5-canvas-folder
branch
from
August 5, 2026 14:30
c4b7dec to
3d3c9d3
Compare
jderochervlk
force-pushed
the
codex/option5-canvas-folder
branch
from
August 5, 2026 14:50
3d3c9d3 to
673b577
Compare
jderochervlk
force-pushed
the
codex/option5-canvas-folder
branch
2 times, most recently
from
August 5, 2026 15:45
f3d9cd1 to
e1055cf
Compare
jderochervlk
force-pushed
the
codex/option5-canvas-folder
branch
from
August 5, 2026 17:40
e1055cf to
bc00a0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue: #342
Stack context
Part 23 of the Option 5 folder-feature stack.
Review this PR as the incremental diff against #332.
Summary
src/Canvasto the targetsrc/canvasfolderCanvasfeatureDependency note
The proposal listed Geometry and HTML. The current Canvas bindings also accept
SVGElementimage values andHTMLVideoElementmedia values, so the compiler-proven closure additionally impliesWebAPI.SVGandWebAPI.Media.Temporary state
VideoColorSpaceremains in the legacy DOM folder; Canvas uses the foundationalDOM.videoColorSpacetype and does not require that interface moduleWebAPI.DOMsource entry remains until its remaining interfaces have been assignedReview focus
Verification
node_modules/.bin/rescript cleannode_modules/.bin/rescript build --prod --features DOM,Event,DOMPlatform,Animation,CSSOM,Geometry,DOMNodes,File,HTML,Media,SVG,Canvasnpm run buildnpm testnpm run format:checkgit diff --check