refactor: establish Window folder feature - #339
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bcd58c8e5b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "dir": "src/window", | ||
| "subdirs": true, | ||
| "feature": "WebAPI.DOM", | ||
| "feature": "Window", |
There was a problem hiding this comment.
Register the consolidated directory with documentation tooling
Moving HistoryTypes.res and VisualViewportTypes.res into this directory without updating scripts/unmonorepo/feature-spec.mjs leaves docs/utils.js looking for them in the deleted src/History and src/VisualViewport directories. Its apiModules filter therefore drops both API groups, removing the History and VisualViewport documentation routes; docs/llm.js also has no specByDir entry for public files under src/window. Update the documentation feature mapping as part of this consolidation.
Useful? React with 👍 / 👎.
bcd58c8 to
12729ec
Compare
Tracking issue: #342
Stack context
Part 29 of the Option 5 folder-feature stack.
Review this PR as the incremental diff against #338.
Summary
src/windowfolder on the unqualified internalWindowfeatureWebAPI.DOMsource entry and the old standalone History/VisualViewport source featuresDependency note
The provisional map listed only HTML. Existing Window, Document, and global signatures also expose Media, Storage, Messaging, Crypto, Performance, and ViewTransitions types. Those public domains are declared explicitly; HTML already supplies DOMNodes, Animation, CSSOM, Geometry, File, and foundational event/DOM layers.
Resolved temporary state
This PR removes the broad source feature named
WebAPI.DOM. Supported qualified features can now expand through the top-level implication map without colliding with a legacy source entry;WebAPI.Windowwas verified directly.Temporary state
WebWorkersTypescache/worker support module andBaseFilefoundation coupling remain for final helper cleanupReview focus
Verification
node_modules/.bin/rescript cleannode_modules/.bin/rescript build --prod --features WebAPI.Windownpm run buildnpm testnpm run format:checkgit diff --check