Skip to content

refactor: establish Window folder feature - #339

Open
jderochervlk wants to merge 1 commit into
codex/option5-device-screen-orientationfrom
codex/option5-window-folder
Open

refactor: establish Window folder feature#339
jderochervlk wants to merge 1 commit into
codex/option5-device-screen-orientationfrom
codex/option5-window-folder

Conversation

@jderochervlk

@jderochervlk jderochervlk commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Tracking issue: #342

Stack context

Part 29 of the Option 5 folder-feature stack.

Review this PR as the incremental diff against #338.

Summary

  • add the target src/window folder on the unqualified internal Window feature
  • move Window, Document, browser globals, Location, XPath, CustomElementRegistry, and IdleDeadline out of the legacy DOM folder
  • consolidate History and VisualViewport into the Window domain
  • add the supported Window feature with its compiler-proven public dependencies
  • remove the legacy qualified WebAPI.DOM source entry and the old standalone History/VisualViewport source features
  • preserve every existing flat public module path

Dependency note

The provisional map listed only HTML. Existing Window, Document, and global signatures also expose Media, Storage, Messaging, Crypto, Performance, and ViewTransitions types. Those public domains are declared explicitly; HTML already supplies DOMNodes, Animation, CSSOM, Geometry, File, and foundational event/DOM layers.

Resolved temporary state

This PR removes the broad source feature named WebAPI.DOM. Supported qualified features can now expand through the top-level implication map without colliding with a legacy source entry; WebAPI.Window was verified directly.

Temporary state

  • the mixed WebWorkersTypes cache/worker support module and BaseFile foundation coupling remain for final helper cleanup
  • automated feature-graph guardrails remain deferred to the next PR, as requested, now that the complete folder stack exists

Review focus

  • Window folder membership
  • the expanded dependency closure
  • removal of the legacy source-feature collision
  • History and VisualViewport consolidation

Verification

  • node_modules/.bin/rescript clean
  • node_modules/.bin/rescript build --prod --features WebAPI.Window
  • npm run build
  • npm test
  • npm run format:check
  • git diff --check

Copy link
Copy Markdown
Collaborator Author

@codex

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bcd58c8e5b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread rescript.json
Comment on lines +294 to +296
"dir": "src/window",
"subdirs": true,
"feature": "WebAPI.DOM",
"feature": "Window",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Register the consolidated directory with documentation tooling

Moving HistoryTypes.res and VisualViewportTypes.res into this directory without updating scripts/unmonorepo/feature-spec.mjs leaves docs/utils.js looking for them in the deleted src/History and src/VisualViewport directories. Its apiModules filter therefore drops both API groups, removing the History and VisualViewport documentation routes; docs/llm.js also has no specByDir entry for public files under src/window. Update the documentation feature mapping as part of this consolidation.

Useful? React with 👍 / 👎.

@jderochervlk
jderochervlk force-pushed the codex/option5-window-folder branch from bcd58c8 to 12729ec Compare August 4, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant