Skip to content

refactor: establish Window folder feature #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jderochervlk wants to merge 2 commits into from
Open

refactor: establish Window folder feature #339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
625002b
refactor: establish Window folder feature
jderochervlk Aug 3, 2026
b207636
fix: isolate final DOM feature closure
jderochervlk Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 15 additions & 19 deletions rescript.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "@rescript/webapi",
"namespace": "WebAPI",
"features": {
"WebAPI.DOM": ["DOM", "Event"],
"WebAPI.DOM": ["DOM"],
"WebAPI.Event": ["WebAPI.DOM", "Event"],
"WebAPI.DOMPlatform": ["WebAPI.Event", "DOMPlatform"],
"WebAPI.Animation": ["WebAPI.Event", "Animation"],
Expand All @@ -16,6 +16,16 @@
"DOMNodes"
],
"WebAPI.HTML": ["WebAPI.DOMNodes", "WebAPI.File", "HTML"],
"WebAPI.Window": [
"WebAPI.HTML",
"WebAPI.Media",
"WebAPI.Storage",
"WebAPI.Messaging",
"WebAPI.Crypto",
"WebAPI.Performance",
"WebAPI.ViewTransitions",
"Window"
],
"WebAPI.Media": ["WebAPI.HTML", "Media"],
"WebAPI.WebAudio": ["WebAPI.Media", "WebAPI.Messaging", "WebAudio"],
"WebAPI.SVG": ["WebAPI.DOMNodes", "WebAPI.Geometry", "SVG"],
Expand Down Expand Up @@ -281,14 +291,16 @@
]
},
{
"dir": "src/DOM",
"dir": "src/window",
"subdirs": true,
"feature": "WebAPI.DOM",
"feature": "Window",
Comment on lines +294 to +296

@chatgpt-codex-connector chatgpt-codex-connector Bot Aug 4, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Register the consolidated directory with documentation tooling

Moving HistoryTypes.res and VisualViewportTypes.res into this directory without updating scripts/unmonorepo/feature-spec.mjs leaves docs/utils.js looking for them in the deleted src/History and src/VisualViewport directories. Its apiModules filter therefore drops both API groups, removing the History and VisualViewport documentation routes; docs/llm.js also has no specByDir entry for public files under src/window. Update the documentation feature mapping as part of this consolidation.

Useful? React with 👍 / 👎.

"public": [
"CustomElementRegistry",
"Document",
"History",
"IdleDeadline",
"Location",
"VisualViewport",
"Window",
"XPathExpression",
"XPathResult"
Expand Down Expand Up @@ -357,14 +369,6 @@
"WebMIDI"
]
},
{
"dir": "src/History",
"subdirs": true,
"feature": "WebAPI.History",
"public": [
"History"
]
},
{
"dir": "src/storage",
"subdirs": true,
Expand Down Expand Up @@ -491,14 +495,6 @@
"ViewTransition"
]
},
{
"dir": "src/VisualViewport",
"subdirs": true,
"feature": "WebAPI.VisualViewport",
"public": [
"VisualViewport"
]
},
{
"dir": "src/web-audio",
"subdirs": true,
Expand Down
0 src/DOM/CustomElementRegistry.res → src/window/CustomElementRegistry.res
View file
Open in desktop
File renamed without changes.
0 src/DOM/Document.res → src/window/Document.res
View file
Open in desktop
File renamed without changes.
0 src/DOM/DomGlobal.res → src/window/DomGlobal.res
View file
Open in desktop
File renamed without changes.
0 src/History/History.res → src/window/History.res
View file
Open in desktop
File renamed without changes.
0 src/History/HistoryTypes.res → src/window/HistoryTypes.res
View file
Open in desktop
File renamed without changes.
0 src/DOM/IdleDeadline.res → src/window/IdleDeadline.res
View file
Open in desktop
File renamed without changes.
0 src/DOM/Location.res → src/window/Location.res
View file
Open in desktop
File renamed without changes.
0 src/VisualViewport/VisualViewport.res → src/window/VisualViewport.res
View file
Open in desktop
File renamed without changes.
0 src/VisualViewport/VisualViewportTypes.res → src/window/VisualViewportTypes.res
View file
Open in desktop
File renamed without changes.
0 src/DOM/Window.res → src/window/Window.res
View file
Open in desktop
File renamed without changes.
0 src/DOM/XPathExpression.res → src/window/XPathExpression.res
View file
Open in desktop
File renamed without changes.
0 src/DOM/XPathResult.res → src/window/XPathResult.res
View file
Open in desktop
File renamed without changes.
Loading